Skip to content

chore(deps): bump github.com/weaviate/weaviate from 1.30.20 to 1.38.0 in /modules/weaviate - #3829

Open
dependabot[bot] wants to merge 1 commit into
mainfrom
dependabot/go_modules/modules/weaviate/github.com/weaviate/weaviate-1.38.0
Open

chore(deps): bump github.com/weaviate/weaviate from 1.30.20 to 1.38.0 in /modules/weaviate#3829
dependabot[bot] wants to merge 1 commit into
mainfrom
dependabot/go_modules/modules/weaviate/github.com/weaviate/weaviate-1.38.0

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Jul 30, 2026

Copy link
Copy Markdown
Contributor

Bumps github.com/weaviate/weaviate from 1.30.20 to 1.38.0.

Release notes

Sourced from github.com/weaviate/weaviate's releases.

v1.38.0 - HFresh, Namespaces, Nested Object Filtering, Alter Schema Reindex property

Breaking Changes

none

HFresh (GA)

Extensive improvements including numerous performance optimizations reducing memory usage, disk writes, and allocations.

Namespaces (Preview)

Namespaces add control-plane and data isolation between users on a shared cluster.

... (truncated)

Commits
  • 73b12b1 prepare release v1.38.0
  • 932014a Merge pull request #11650 from weaviate/merge-stable-v1.37-into-stable-v1.38
  • c33c55e Merge remote-tracking branch 'origin/stable/v1.37' into merge-stable-v1.37-in...
  • 7a37bbc Merge pull request #11649 from weaviate/fix/hf-cache-info
  • c04bdfc Merge pull request #11632 from weaviate/deterministic-ordering-for-equal-dist...
  • f6db408 Merge branch 'stable/v1.37' into fix/hf-cache-info
  • ba3892c Use local HuggingFace cache for ann-datasets to avoid 429
  • f5b1798 Merge remote-tracking branch 'origin/stable/v1.37' into merge-stable-v1.37-in...
  • 8d0ca11 Merge pull request #11648 from weaviate/merge-stable-v1.36-into-stable-v1.37
  • 434067e Merge remote-tracking branch 'origin/stable/v1.36' into merge-stable-v1.36-in...
  • Additional commits viewable in compare view

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.

Bumps [github.com/weaviate/weaviate](https://github.com/weaviate/weaviate) from 1.30.20 to 1.38.0.
- [Release notes](https://github.com/weaviate/weaviate/releases)
- [Commits](weaviate/weaviate@v1.30.20...v1.38.0)

---
updated-dependencies:
- dependency-name: github.com/weaviate/weaviate
  dependency-version: 1.38.0
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot Bot added dependencies Dependencies or external services go Pull requests that update go code labels Jul 30, 2026
@dependabot
dependabot Bot requested a review from a team as a code owner July 30, 2026 23:50
@netlify

netlify Bot commented Jul 30, 2026

Copy link
Copy Markdown

Deploy Preview for testcontainers-go ready!

Name Link
🔨 Latest commit 138b57c
🔍 Latest deploy log https://app.netlify.com/projects/testcontainers-go/deploys/6a6be34cc59ded00082d7cae
😎 Deploy Preview https://deploy-preview-3829--testcontainers-go.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions github-actions Bot added the chore Changes that do not impact the existing functionality label Jul 30, 2026
@mdelapenya mdelapenya removed the chore Changes that do not impact the existing functionality label Aug 4, 2026
@mdelapenya

Copy link
Copy Markdown
Member

The 1.25.x test fails because github.com/weaviate/weaviate v1.38.0 requires go 1.26 — the module's go.mod was bumped from go 1.25.0 to go 1.26 by dependabot as part of this update.

The CI matrix runs tests against both Go 1.25.x and 1.26.x (GOTOOLCHAIN=local), so the 1.25.x build fails with:

go: go.mod requires go >= 1.26 (running go 1.25.12; GOTOOLCHAIN=local)

The 1.26.x test passes. The CI currently has no mechanism to skip modules whose go.mod requires a higher Go version than the matrix entry.

@mdelapenya — this needs a decision on how to handle modules that require Go 1.26 while the core library still targets Go 1.25. Options:

  1. Skip modules requiring go 1.26 in the 1.25.x CI matrix entry
  2. Wait until the core library bumps to Go 1.26
  3. Pin weaviate to a version compatible with Go 1.25

@mdelapenya

Copy link
Copy Markdown
Member

The 1.25.x test fails because weaviate v1.38.0 requires go 1.26 — Go 1.25 refuses to even resolve the module. This is a hard constraint that can't be worked around at the module level.

Root cause: ci-test-go.yml unconditionally runs go build ./... for every module against both Go 1.25.x and 1.26.x. When a module's go.mod declares go 1.26, the 1.25.x build fails with go: go.mod requires go >= 1.26.

Proposed fix: add a compatibility check step to .github/workflows/ci-test-go.yml that skips build/test when the installed Go version is lower than what go.mod requires. After the "Set up Go" step, add:

      - name: Check Go version compatibility
        id: go-compat
        working-directory: ./${{ inputs.project-directory }}
        shell: bash
        run: |
          REQUIRED=$(grep '^go ' go.mod | awk '{print $2}')
          INSTALLED=$(go env GOVERSION | sed 's/^go//')
          echo "Module requires go ${REQUIRED}, installed ${INSTALLED}"
          if printf '%s\n%s' "${REQUIRED}" "${INSTALLED}" | sort -V | head -n1 | grep -qx "${REQUIRED}"; then
            echo "compatible=true" >> $GITHUB_OUTPUT
          else
            echo "::warning::Skipping: module requires go ${REQUIRED} but go ${INSTALLED} is installed"
            echo "compatible=false" >> $GITHUB_OUTPUT
          fi

Then guard all subsequent steps with if: steps.go-compat.outputs.compatible == 'true'.

I can't push this change because the token lacks the workflow scope. @mdelapenya could you apply this CI fix?

@mdelapenya

Copy link
Copy Markdown
Member

I tried to push the CI workflow fix directly but the token lacks the workflow scope — GitHub blocks all modifications to .github/workflows/ files via OAuth without that scope (API, git push, and GraphQL all rejected).

@mdelapenya — to unblock this PR, please apply this patch to the dependabot branch:

# From the repo root, on the dependabot branch:
curl -sL '<patch_url>' | git apply
git add .github/workflows/ci-test-go.yml
git commit -m 'ci: skip test jobs when module requires a newer Go version'
git push

Or manually: add a "Check Go version compatibility" step after "Set up Go" in ci-test-go.yml that compares go.mod's required version against the installed version, and guard all subsequent steps with if: steps.go-compat.outputs.compatible == 'true'. Full diff in my previous comment.

@mdelapenya

Copy link
Copy Markdown
Member

@mdelapenya gentle ping — this PR still needs two things to proceed:

  1. Merge conflict: the grpc bump in chore(deps): bump google.golang.org/grpc from 1.79.3 to 1.82.1 in /modules/weaviate #3820 (merged Aug 3) conflicts with this branch. A @dependabot rebase should fix it.
  2. CI fix: the Go 1.25.x test will always fail because weaviate v1.38.0 requires go 1.26. The CI workflow (ci-test-go.yml) needs a version-compatibility guard step as described in my earlier comment — this requires workflow scope to push.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Dependencies or external services go Pull requests that update go code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant