Add topology to GUI configuration fields - #7
Merged
Merged
Conversation
The 'topology' field holds a string enum value ('single_chain' or
'two_chain_shared_vest') but was missing from the string-exclusion set
in _read_cfg(), causing it to be treated as a float field and raising:
ValueError: could not convert string to float: 'two_chain_shared_vest'
https://claude.ai/code/session_01Cjh3nEv91RsUG7MxAukNPg
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added "topology" to the list of configuration fields that are read from the GUI case configuration.
Changes
_read_cfg()method execution in the GUI application configuration readerDetails
The "topology" field is now included alongside other model configuration fields (int_model, exit_model, external_model, etc.) when reading the GUI case configuration. This ensures topology settings are properly loaded and available for the application.
https://claude.ai/code/session_01Cjh3nEv91RsUG7MxAukNPg