Repository navigation
Conversation
The README links [LICENSE](LICENSE), which 404s because the file is LICENSE.txt. Renaming the file fixes the link and matches the other test-kitchen plugins, which all use LICENSE. .yardopts named the old path too, so it is updated to match. The gemspec builds its file list from git ls-files and needs no change; the built gem still ships the license. Signed-off-by: Tim Smith <tim@mondoo.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The README links
[LICENSE](LICENSE), but the file isLICENSE.txt— so that link 404s on GitHub today. Renaming the file fixes it, and matches the rest of the test-kitchen plugins: 18 of 21 already useLICENSE, and kitchen-openstack was moved over in #258..yardoptslisted the old path as an extra file, so it is updated to match.The gemspec builds
spec.filesfromgit ls-files, so it needs no change and the built gem still ships the license — verified below.Verification
Not fixed here
yardemits two warnings against the license file:Those come from the Apache boilerplate's
[yyyy]and[name of copyright owner]placeholders being parsed as markdown links. They are unaffected by the rename — I confirmed they persist with the new filename — and fixing them is a separate decision about whether the license belongs in the YARD extra-files list at all.