Repository navigation
fix: require cookstyle/chefstyle so style checks actually run - #43
Merged
Merged
Conversation
The Rakefile required the standalone chefstyle gem, which is not in the bundle -- only cookstyle is. The require therefore hit the LoadError branch and the :style task was never defined. Signed-off-by: Tim Smith <tsmith84@proton.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Rakefile requires the standalone
chefstylegem:but
chefstyleappears in neither the Gemfile nor the gemspec — the:cookstylegroup declarescookstyleand nothing else. Therequiretherefore falls into therescue LoadErrorbranch, the:styletask is never defined, and style checking silently does not happen.Chefstyle was absorbed into Cookstyle, which ships the rule set as
cookstyle/chefstyle(it setsCHEFSTYLE_CONFIG = trueand then loads cookstyle). Requiring that path uses the gem that is actually installed. kitchen-pester's Rakefile already does exactly this.Expect
rake styleto start reporting offenses that were previously going unchecked.