Repository navigation
test: cover configuration, metadata, and the untested workflow branches - #42
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
35 examples for a driver with 18 methods, and one of them was testing the wrong thing.
The example that could not fail
A copy of the
truecontext with the name changed and nothing else. Both branches of#verify_ssl?were asserting the same thing, so thefalsepath — the one that decides whether the driver validates the vRO server's TLS certificate — had never been executed by a test. Fixed to setfalseand expecttrue.What was untested
#namekitchen listprintsplugin_versionkitchen diagnoseoutputvro_disable_ssl_verifydefaulting tofalseis a security-relevant default and nothing pinned itrequired_config#set_workflow_vars#workflow_successful?The
#set_workflow_varstest is the one I would keep if I could keep only one: the memoization reset is load bearing and invisible, and a refactor that dropped@vro_client = nilwould have gone green.Verification
rake test— 51 examples, 0 failures (35 before; 16 new, 1 corrected)cookstyle --chefstyle— clean;lib/is untouched by this PR