feat: add reusable market helper APIs - #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MarketInfoandTradingPermissionshelpers for market status, order capability, quote precision, notional limits, and effective lot constraintsKlinecollection helpers for dedup/merge/window operationsMarketDatafocused on atomic fetch operations by requiringmarket(&Symbol)and moving map/history assembly intoMarketDataExtexchangeInfo(symbol=...)instead of routing through a full-market fetchNotes
#[async_trait]stays in place intentionally becauseExchangeHandlestoresArc<dyn MarketData>and the current handle model relies on object-safe async traitslast_prices(Option<&[Symbol]>)and the sharedmkt_core::Errorsurface are unchanged in this round; the follow-up focuses on the concrete performance and trait-boundary issuesCommit Breakdown
8d6b750Add market helper methodsb97fcb3Add kline collection helpersba0ef99Fold market data helpers intoMarketData4dd6f6bSplit market data helpers from core traitTests
cargo test -p mkt-types -p mkt-core