fix(cli): prevent subshell hang when capturing 'claude -p "check"' - #20
Open
jketreno wants to merge 1 commit into
Open
fix(cli): prevent subshell hang when capturing 'claude -p "check"'#20jketreno wants to merge 1 commit into
jketreno wants to merge 1 commit into
Conversation
Problem: The call to `timeout 300s claude -p 'check'` was not returning, however when I ran `claude -p 'check'` at the CLI, the process did return. - add run_claude_check() helper that prefers 'timeout --foreground' - fallback to 'script' (PTY) when a TTY is required - replace direct timeout calls and update debug message - prevents SIGTTOU/background-stop when used in command substitution
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: The call to
timeout 300s claude -p 'check'was not returning, however when I ranclaude -p 'check'at the CLI, the process did return.