changed one pointer assignment with a __restrict to a __declspec(rest…#86
Open
terrylyons wants to merge 1 commit into
Open
changed one pointer assignment with a __restrict to a __declspec(rest…#86terrylyons wants to merge 1 commit into
terrylyons wants to merge 1 commit into
Conversation
…rict) on the return type of the two function tile_ptr() methods
Collaborator
|
Unfortunately I was wrong about GCC having an equivalent function attribute for restricted return values. This needs a bit more thought. I'll comment out the offending __restrict for now |
Owner
Author
|
Can one just declare the return type to include p__restrict ?
Sent from Outlook for iOS<https://aka.ms/o0ukef>
…________________________________
From: inakleinbottle ***@***.***>
Sent: Friday, May 5, 2023 9:33:35 AM
To: terrylyons/libalgebra ***@***.***>
Cc: Terry Lyons ***@***.***>; Author ***@***.***>
Subject: Re: [terrylyons/libalgebra] changed one pointer assignment with a __restrict to a __declspec(rest… (PR #86)
Unfortunately I was wrong about GCC having an equivalent function attribute for restricted return values. This needs a bit more thought. I'll comment out the offending __restrict for now
—
Reply to this email directly, view it on GitHub<#86 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABQWN6YJ2URKB3SWPWUTDCDXES3N7ANCNFSM6AAAAAAXVNZGLA>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Collaborator
|
yes maybe. I need to check that this works. I'll let you know |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…rict) on the return type of the two function tile_ptr() methods