Add typehints#11
Merged
Merged
Conversation
Author
|
Hi @seanmacavaney can you review? |
Author
|
@cmacdonald @seanmacavaney can you review? |
Collaborator
|
Thanks for this, nice work. We should add a mypy GHA that verifies the types. Can you take a style.yml file from another of our projects? |
Author
|
Added ruff config |
Author
|
I tried to add |
Collaborator
|
Here is the mypy output: |
Samoed
force-pushed
the
Samoed-patch-1
branch
from
September 5, 2025 08:40
20fb907 to
5d763a7
Compare
cmacdonald
reviewed
Sep 5, 2025
cmacdonald
reviewed
Sep 5, 2025
cmacdonald
reviewed
Sep 5, 2025
cmacdonald
reviewed
Sep 5, 2025
Collaborator
|
added some comments - nearly there @Samoed ! |
Author
|
Changed ruff to singe quotes |
Collaborator
|
LGTM. are you happy @seanmacavaney ? |
Collaborator
|
To avoid increasing the min supported python version, I switched to I think this is good to go, I'll merge and release. Thanks a bunch @Samoed! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.