fix(lint): resolve clippy --all-targets -D warnings gate (4 findings)#932
Open
AlexMikhalev wants to merge 1 commit into
Open
fix(lint): resolve clippy --all-targets -D warnings gate (4 findings)#932AlexMikhalev wants to merge 1 commit into
AlexMikhalev wants to merge 1 commit into
Conversation
- weather_report: collapse nested if-let/if into let-chain (collapsible_if)
- merge_coordinator: wrap const assertions in const{} blocks (assertions_on_constants)
- terraphim_validation: remove trivial assert!(true) (assertions_on_constants)
- terraphim_server: move build_router_for_tests before mod tests (items_after_test_module)
`cargo clippy --workspace --all-targets -- -D warnings` now passes clean.
Co-Authored-By: Ferrox <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes all 4 clippy lint failures surfaced by `cargo clippy --workspace --all-targets -- -D warnings` as filed in Gitea #2933.
collapsible_if: collapse nestedif let Some(detail)+if !detail.is_empty()into let-chainassertions_on_constants(×2): wrap compile-time const assertions inconst { assert!(...) }blocksassertions_on_constants: remove deadassert!(true)from testitems_after_test_module: movebuild_router_for_testsbefore#[cfg(test)] mod testsTest plan
Closes terraphim/terraphim-ai#2933 (Gitea)
🤖 Generated with Terraphim AI