Fix #2503: implement WorkflowStep tracking in workflow trace API#925
Merged
Conversation
AlexMikhalev
force-pushed
the
task/2503-workflow-step-tracking
branch
2 times, most recently
from
9cf558c to
086a06b
Compare
…Refs #2503 Add WorkflowStep and StepStatus types to the workflow module so that individual execution steps can be recorded against a running workflow. The /api/workflow/:id/trace endpoint now returns the accumulated steps instead of a hardcoded empty array. Changes: - Add WorkflowStep struct (id, name, status, started_at, completed_at, output) - Add StepStatus enum (Running, Completed, Failed) - Add steps: Vec<WorkflowStep> to WorkflowStatus - Add record_workflow_step() public helper for handlers to push step records - Fix get_execution_trace() to serialise status.steps instead of [] - Update create_workflow_session() to initialise steps: vec![] - Fix existing simple_workflow_test.rs to include the new field - Add 3 unit tests: empty initial state, single step round-trip, ordering Co-Authored-By: Terraphim AI <noreply@anthropic.com>
…xecutor Refs #2503 Call record_workflow_step() after each step in execute_prompt_chain so WorkflowStatus.steps is populated during real workflow execution. Also replace the hardcoded duration_ms with the actual elapsed time.
AlexMikhalev
force-pushed
the
task/2503-workflow-step-tracking
branch
from
52e914e to
4a81b9a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The `/api/workflow/:id/trace` endpoint was returning an empty `steps: []` array (hardcoded TODO). This PR implements proper step tracking so callers can diagnose workflow failures.
Changes:
Verification
```bash
cargo test -p terraphim_server --lib # 3 new unit tests pass
cargo test -p terraphim_server # all 11 integration tests pass
cargo clippy -p terraphim_server -- -D warnings # clean
cargo fmt -p terraphim_server -- --check # clean
```
Refs terraphim/terraphim-ai#2503 (Gitea)