Skip to content

chore: Update the examples to use the new major version #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
guilherme-hosoda-cit wants to merge 3 commits into
base: main
Choose a base branch
from
Open

chore: Update the examples to use the new major version #107

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ccfa5b9
chore: fix simple example modules version
guilherme-hosoda-cit Mar 11, 2026
6a706c6
chore: fix dlp api example modules version
guilherme-hosoda-cit Mar 11, 2026
400fb19
Merge branch 'main' into chore/fix-simple-example-modules-version
guilherme-hosoda-cit Aug 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions examples/dlp_api_example/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ locals {

module "dataflow-bucket" {
source = "terraform-google-modules/dataflow/google//modules/dataflow_bucket"
version = "~> 2.0"
version = "~> 3.0"

name = local.gcs_bucket_name
region = var.region
Expand Down Expand Up @@ -110,7 +110,7 @@ EOF

module "dataflow-job" {
source = "terraform-google-modules/dataflow/google//modules/legacy"
version = "~> 2.0"
version = "~> 3.0"

project_id = var.project_id
name = "dlp_example_${null_resource.download_sample_cc_into_gcs.id}_${null_resource.deinspection_template_setup.id}"
Expand Down
4 changes: 2 additions & 2 deletions examples/simple_example/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,13 +11,13 @@ As featured in this example, using a single regional bucket for storing your job
Also, to optimize your jobs performance, this bucket should always in the corresponding region of the zones in which your jobs are running.

## Running the example
Make sure you grant the addtional permissions below to the service account execute the module:
Make sure you grant the additional permissions below to the service account execute the module:

- roles/compute.networkAdmin


### Controller Service Account
This example features the use of a controller service accoun which is specified with the `service_account_email` input variables.
This example features the use of a controller service account which is specified with the `service_account_email` input variables.
We recommend using a custome service account with fine-grained access control to mitigate security risks. See more about controller service accounts [here](https://cloud.google.com/dataflow/docs/concepts/security-and-permissions#controller_service_account)


Expand Down
6 changes: 3 additions & 3 deletions examples/simple_example/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ module "vpc" {

module "dataflow-bucket" {
source = "terraform-google-modules/dataflow/google//modules/dataflow_bucket"
version = "~> 2.0"
version = "~> 3.0"

name = local.gcs_bucket_name
region = var.region
Expand All @@ -62,7 +62,7 @@ module "dataflow-bucket" {

module "dataflow-job" {
source = "terraform-google-modules/dataflow/google//modules/legacy"
version = "~> 2.0"
version = "~> 3.0"

project_id = var.project_id
name = "wordcount-terraform-example"
Expand All @@ -84,7 +84,7 @@ module "dataflow-job" {

module "dataflow-job-2" {
source = "terraform-google-modules/dataflow/google//modules/legacy"
version = "~> 2.0"
version = "~> 3.0"

project_id = var.project_id
name = "wordcount-terraform-example-2"
Expand Down