feat: add Dataflow example for confidential compute - #106
Conversation
erlanderlo
left a comment
erlanderlo
left a comment
There was a problem hiding this comment.
thanks for your help with this! some comments to consider
| service_account_email = var.service_account_email | ||
| network_name = module.vpc.network_self_link | ||
| subnetwork = module.vpc.subnets_self_links[0] | ||
| use_public_ips = true |
| */ | ||
|
|
||
| module "example" { | ||
| source = "../../../examples/confidential_compute_example" |
There was a problem hiding this comment.
since this is already in the example direction, consider just calling this "confidential_computing" instead of "confidential_computing_example" unless there is an existing pattern for this.
There was a problem hiding this comment.
looks like this is following convention
| @@ -0,0 +1,82 @@ | |||
| # Copyright 2019 Google LLC | |||
| - name: "confidential_compute_example" | ||
| driver: | ||
| name: "terraform" | ||
| command_timeout: 1800 |
There was a problem hiding this comment.
maybe indicate the reasoning want to wait; perhaps because the workers need to spin up, as well?
There was a problem hiding this comment.
this follows the other timeout for the DF examples
erlanderlo
left a comment
erlanderlo
left a comment
There was a problem hiding this comment.
LGTM - thanks for your contribution and addressing my comments
| @@ -0,0 +1,82 @@ | |||
| # Copyright 2026 Google LLC | |||
There was a problem hiding this comment.
Ruby based test is deprecated, can you move to go based test like this! https://github.com/terraform-google-modules/terraform-google-sql-db/tree/main/test/integration/mssql-public
There was a problem hiding this comment.
@q2w Thank you for the feedback. I have made the modifications to use the new framework. Could you please review it again?
There was a problem hiding this comment.
I decided not to migrate the other test in this PR to avoid a large refactor. However, I can open a dedicated PR for the other example right after.
|
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days |
|
Hi @q2w, could you please take a look at this PR or point me to someone who can? Thanks in advance |
3 participants
This PR adds a new example on how to use the Dataflow module to configure jobs with Confidential Computing, providing an extra layer of security for data during processing.