fix terminfo header memory check - #100
Merged
Merged
Conversation
Contributor
|
Good catch. Thank you @cmdlin. |
Author
|
Hi @adsr, is there any plan to support Windows(_WIN32/_WIN64)? |
Contributor
|
Yes, there are PRs for Windows support here and here. I didn't like adding that many ifdefs, so I didn't merge either. I think I'll either change this to be a codegen step, or maintain a completely separate header file for Windows. Either would be easy. The more difficult thing to figure out is the test suite. I don't know the Windows equivalent of running a test program inside xterm inside Xvfb, using xvkbd to send input, dumping the terminal contents ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in function
parse_terminfo_caps, header section at least check six short integers