feat(ui): label github_hmac as 'GitHub / Sentry (X-Hub-Signature-256)' in signing mode picker#14
Merged
Merged
Conversation
…' in signing mode picker Adds human-readable labels for all signing modes so the purpose of each option is obvious at a glance. Also surfaces the description hint in the existing trigger editor (TriggerEditor), which previously only appeared in the new trigger creation form. Closes TEN-325. Co-Authored-By: Paperclip <noreply@paperclip.ing>
lavie
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this change exists
When TEN-321 was investigated,
github_hmacalready correctly handled GitHub'sX-Hub-Signature-256format — but three GitHub webhook triggers were created withhmac_sha256instead. The root cause: the signing mode dropdown showed raw internal keys (github_hmac,hmac_sha256) with no labels, making it impossible to guess which one to pick for a GitHub webhook.This is the second fix from TEN-325: surface
github_hmacas the obviously-correct choice before the next misconfiguration occurs.How this PR fixes it
signingModeLabelsmap that gives each mode a human-readable name.github_hmacis now displayed as "GitHub / Sentry (X-Hub-Signature-256)" — the header name makes its purpose unambiguous.Technical summary
ui/src/pages/RoutineDetail.tsx: addsigningModeLabelsconstant; usesigningModeLabels[mode] ?? modein bothSelectItemmaps; add description<p>toTriggerEditor's webhook section.Verification
Change is purely display-layer. The underlying
signingModevalue written to the API is unchanged (still"github_hmac","hmac_sha256", etc.) — the label only affects what the user reads in the dropdown. TypeScript pattern is identical to the existingsigningModeDescriptionsmap.