Skip to content

feat(ui): label github_hmac as 'GitHub / Sentry (X-Hub-Signature-256)' in signing mode picker#14

Merged
lavie merged 1 commit into
masterfrom
feature/ten-325-github-hmac-label
May 5, 2026
Merged

feat(ui): label github_hmac as 'GitHub / Sentry (X-Hub-Signature-256)' in signing mode picker#14
lavie merged 1 commit into
masterfrom
feature/ten-325-github-hmac-label

Conversation

@marvin-tensorleap

@marvin-tensorleap marvin-tensorleap commented May 5, 2026

Copy link
Copy Markdown
Collaborator

Why this change exists

When TEN-321 was investigated, github_hmac already correctly handled GitHub's X-Hub-Signature-256 format — but three GitHub webhook triggers were created with hmac_sha256 instead. The root cause: the signing mode dropdown showed raw internal keys (github_hmac, hmac_sha256) with no labels, making it impossible to guess which one to pick for a GitHub webhook.

This is the second fix from TEN-325: surface github_hmac as the obviously-correct choice before the next misconfiguration occurs.

How this PR fixes it

  • Adds a signingModeLabels map that gives each mode a human-readable name. github_hmac is now displayed as "GitHub / Sentry (X-Hub-Signature-256)" — the header name makes its purpose unambiguous.
  • Both the new-trigger creation form and the existing trigger editor now use labels instead of raw keys.
  • The existing trigger editor now also shows the description hint below the select (it previously only appeared in the creation form), so users editing an existing trigger can see what the selected mode does.

Technical summary

  • ui/src/pages/RoutineDetail.tsx: add signingModeLabels constant; use signingModeLabels[mode] ?? mode in both SelectItem maps; add description <p> to TriggerEditor's webhook section.

Verification

Change is purely display-layer. The underlying signingMode value written to the API is unchanged (still "github_hmac", "hmac_sha256", etc.) — the label only affects what the user reads in the dropdown. TypeScript pattern is identical to the existing signingModeDescriptions map.

…' in signing mode picker

Adds human-readable labels for all signing modes so the purpose of each
option is obvious at a glance. Also surfaces the description hint in the
existing trigger editor (TriggerEditor), which previously only appeared
in the new trigger creation form.

Closes TEN-325.

Co-Authored-By: Paperclip <noreply@paperclip.ing>
@marvin-tensorleap marvin-tensorleap changed the title Test feat(ui): label github_hmac as 'GitHub / Sentry (X-Hub-Signature-256)' in signing mode picker May 5, 2026
@marvin-tensorleap marvin-tensorleap self-assigned this May 5, 2026
@lavie lavie merged commit 31692b2 into master May 5, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants