Add PR lifecycle rule to Coder agent onboarding template#11
Open
marvin-tensorleap wants to merge 1 commit into
Open
Add PR lifecycle rule to Coder agent onboarding template#11marvin-tensorleap wants to merge 1 commit into
marvin-tensorleap wants to merge 1 commit into
Conversation
Agents were closing issues as `done` when a GitHub PR was merely code-reviewed (APPROVED) but not yet merged. This adds an explicit PR lifecycle rule to the Coder template so every future coder hire gets the rule from day one. Rule: PR open (including approved) → issue stays in_review. PR merged = done. Code review approved ≠ task done. Closes the onboarding template gap identified in TEN-192 / TEN-191 RCA. Co-Authored-By: Paperclip <noreply@paperclip.ing>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this change exists
Supersedes #9, which was polluted with ~50 upstream commits from paperclipai/paperclip due to the wrong
originremote. The branch was branched from upstream master instead of tensorleap/master (TEN-238).This PR is a clean cherry-pick of the single real commit (
9fa54c16) onto tensorleap/master.How this PR fixes it
Rebased the single genuine commit onto the fork's master using
git cherry-pick, giving a clean 1-file, 17-line diff.Technical summary
devenv/ansible/files/home/AGENTS.md— adds PR lifecycle rule to Coder agent onboarding templateVerification
git log origin/master..ten-192-pr-lifecycle-rule-cleanshows exactly 1 commit (+17/-0)