Add pre-done PR check to heartbeat skill#10
Open
marvin-tensorleap wants to merge 1 commit into
Open
Conversation
Agents were closing issues as done while their GitHub PR was still open, causing premature closure before code actually merged. This adds an explicit pre-done checklist in Step 8 and a critical rule that fires before agents reach for the done status. Co-Authored-By: Paperclip <noreply@paperclip.ing>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this change exists
Agents were prematurely closing issues as
donewhile their linked GitHub PR was still open (not yet merged). This was surfaced in TEN-191 RCA and tracked as TEN-193. Without a structural guardrail in the shared heartbeat skill, every agent was susceptible to the same premature closure pattern.How this PR fixes it
Adds an explicit Done Checklist subsection inside Step 8 — Update status of the heartbeat skill. The checklist makes the open-PR guard a first-class procedural check rather than a learnable inference. A parallel entry is added to the Critical Rules section so the rule is visible even on a quick scan.
Changes
skills/paperclip/SKILL.md— 19 lines added, 0 deleted:New
### Done Checklistsubsection in Step 8 (between status-values line and### Status Quick Guide):in_review, leave comment "issue will close once PR merges"in_review| Merged →done| No PR →doneNew critical rule at the top of the Critical Rules list:
🤖 Generated with Claude Code