fix push override#251
Merged
Merged
Conversation
moshe-kabala
commented
Jun 21, 2026
moshe-kabala
commented
Contributor
- Update api
- CLI: consolidate metric direction + insights into update_metric_config
- CLI: prompt to run evaluation on push when --eval is omitted (default Yes)
The engine contract merged update_metric_direction + update_insights into a single update_metric_config (recalculates metric direction AND insights). Match it in the CLI: - updateActionAliases: metric_config is canonical; the old metric_direction / direction / insights values are kept as back-compat aliases that map to update_metric_config. - change-option picker: "Metric direction" + "Insights" become one "Metric config" option. - FormatEvaluatePlan switch + push --update help text updated. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
… Yes) When `leap push` runs without --eval (or -u, which implies it), interactively ask whether to run evaluation after the push, defaulting to Yes: - New version: "Run evaluate after push?" - Overwrite: ask "What do you want to update?" FIRST, then "Run update-evaluate after push?" (or "Run evaluate after push?" when the changes trigger a full re-evaluate) — so the label matches what will actually run. Skipped when stdin isn't a terminal, so scripted/piped pushes keep the explicit --eval requirement. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
moshe-kabala
force-pushed
the
fix-push-override
branch
from
3fc876b to
f6e9fc7
Compare
roytl
reviewed
Jun 21, 2026
| "metric-config": tensorleapapi.UPDATEACTION_UPDATE_METRIC_CONFIG, | ||
| // update_metric_config recalculates metric direction AND insights, so the | ||
| // former metric-direction / insights values map onto it (back-compat). | ||
| "metric_direction": tensorleapapi.UPDATEACTION_UPDATE_METRIC_CONFIG, |
Contributor
There was a problem hiding this comment.
Why is "metric_direction" appearing twice? Also, what is the difference between "direction" and "metric_direction"
metric_config is the canonical value after the consolidation; the old metric_direction / metric-direction / direction / insights aliases all mapped to it redundantly. Keep only metadata, metric, metric_config (metric-config), visualization (viz). Old values now produce a clear "invalid --update value" error instead of silently aliasing. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
triggerEvaluate gates on in.runEval, but the prompt only returned a bool without setting it — so answering Yes built the right dispatch yet triggerEvaluate bailed out and nothing ran. Set in.runEval = true on confirm (new + overwrite). Also un-gate the canUpdateEvaluate->reset conversion so the prompt label and dispatch are correct without --eval too (a version with no eval data runs a fresh evaluate instead of a doomed update-evaluate). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.