extstore/replay and heartbeat metadata#2216
Open
cconstable wants to merge 2 commits into
Open
Conversation
THardy98
approved these changes
Jul 15, 2026
jmaeagle99
approved these changes
Jul 15, 2026
| const encodedCompletion = await workflowCodecRunner.encodeCompletion(unencodedCompletion); | ||
| if (externalStorage) { | ||
| // skip extstore.store for replay | ||
| if (externalStorage && !this.isReplayWorker) { |
Contributor
There was a problem hiding this comment.
Would love to have a test to validate this behavior, but won't block on it. And should apply this to the other SDKs as well.
Contributor
Author
There was a problem hiding this comment.
I think the logic checks out here. I believe Go does this too. Will verify before release though.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Why?
Checklist