Fix schedule catchup window default#2211
Open
chaptersix wants to merge 1 commit into
Open
Conversation
mjameswh
reviewed
Jul 15, 2026
| // 'overlap' should never be missing on describe, as the server will replace UNSPECIFIED by an actual value | ||
| overlap: decodeScheduleOverlapPolicy(raw.schedule.policies?.overlapPolicy) ?? ScheduleOverlapPolicy.SKIP, | ||
| catchupWindow: optionalTsToMs(raw.schedule.policies?.catchupWindow) ?? 60_000, | ||
| catchupWindow: optionalTsToMs(raw.schedule.policies?.catchupWindow) ?? 365 * 24 * 60 * 60 * 1000, |
Contributor
There was a problem hiding this comment.
Does the server have some form of configuration for that default value? e.g. dynamic config?
If so, then we'd better let that undefined if not explicitly specified by the user, so that the server's default applies.
mjameswh
reviewed
Jul 15, 2026
| * Window could lead to missed Actions. (But you can always {@link ScheduleHandle.backfill}.) | ||
| * | ||
| * @default 1 year | ||
| * When unset, this field is omitted so the Temporal Server applies its default (currently one year). |
Contributor
There was a problem hiding this comment.
This line is inconsistent with the code currently in schedule-client.ts (see my comment at line 440).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
Requests already omitted an unspecified value, but the documentation and defensive response fallback still used the historical one-minute default.
Breaking changes
None.