Support Workflow Update as a Nexus Operation#2194
Open
Evanthx wants to merge 3 commits into
Open
Conversation
Evanthx
force-pushed
the
nexus-update-workflow
branch
from
fc51ac9 to
c219b68
Compare
Evanthx
force-pushed
the
nexus-update-workflow
branch
from
52d2045 to
121ff88
Compare
| // requires server-side support for delivering Workflow Update completion callbacks to Nexus, which | ||
| // the bundled ephemeral server (Temporal 1.31.2) does not yet provide (workflow-run completion | ||
| // callbacks do work there). Enable once the test server delivers Update completion callbacks. | ||
| test.skip('UpdateWorkflow Nexus operation - pending update completes asynchronously via callback', async (t) => { |
Contributor
There was a problem hiding this comment.
Same comment as dotnet, this should be enabled
| case OperationTokenType.UPDATE_WORKFLOW: { | ||
| let updateToken; | ||
| try { | ||
| updateToken = loadUpdateWorkflowOperationToken(token); |
Contributor
There was a problem hiding this comment.
Why are we reparsing the token, we already have opToken?
| /** | ||
| * The Run ID extracted from the operation token. May be empty if the run was not pinned. | ||
| */ | ||
| readonly runId: string; |
Contributor
There was a problem hiding this comment.
The run ID should be know here since the server returns the run ID on the update response
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Why?
Checklist
Closes
How was this tested: