fix(client): correctly handle grpc-js style unimplemented method message#1379
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Add "not implemented" as a valid variation of "is unimplemented"
Why?
Typescript uses grpc-js to create mock servers to assert that all methods defined on services are available on
NativeConnection. Latest core bump fails these tests now since theGetSystemInforequest that always has returnedUNIMPLEMENTEDbefore is now treated as a failure.Checklist
Closes N/A
How was this tested:
New test case
Any docs updates needed?
N/A