Test cloud workflow RPC endpoints#1362
Open
Sushisource wants to merge 3 commits into
Open
Conversation
Sushisource
force-pushed
the
test-all-cloud-rpcs
branch
3 times, most recently
from
5b3d26a to
920fdab
Compare
Sushisource
force-pushed
the
test-all-cloud-rpcs
branch
from
920fdab to
31774f0
Compare
Member
Author
|
My inclination is not to merge this, kinda a lot of code at relatively low value, but wanted to see others' thoughts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Adds a Cloud integration test that probes every api_upstream WorkflowService RPC plus gRPC Health/Check with the default client settings and a no-compression control client.
The test also asserts that every WorkflowService RPC declared in the upstream proto has a probe entry, so newly added RPCs require test coverage.
Validation
Local checks run:
Full Cloud endpoint validation requires CI secrets and will be validated from the draft PR Cloud test job.