Disable newsfeed in UI based on TEMPORAL_DISABLE_NEWS_FETCH env var#1110
Open
tomwheeler wants to merge 1 commit into
Open
Disable newsfeed in UI based on TEMPORAL_DISABLE_NEWS_FETCH env var#1110tomwheeler wants to merge 1 commit into
TEMPORAL_DISABLE_NEWS_FETCH env var#1110tomwheeler wants to merge 1 commit into
Conversation
|
|
chaptersix
reviewed
Jul 6, 2026
| } | ||
|
|
||
| func (s *StartOptions) buildUIServer() *uiserver.Server { | ||
| disableNewsFetch, _ := strconv.ParseBool(os.Getenv("TEMPORAL_DISABLE_NEWS_FETCH")) |
Contributor
There was a problem hiding this comment.
I don't think we should silently fail here. I think it makes sense to include in the start options (unless those are generated somehow)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
Related to #1104
What changed?
This configures the UI server to disable the news feed feature if the
TEMPORAL_DISABLE_NEWS_FETCHenvironment variable is set totrue, as described in the documentation.Checklist
Manual tests
Setup #1 (default case)
Happy path #1 (default case)
Open the Web UI and observe that the news fetch feature is enabled, as it is by default. This is visible by way of a megaphone icon in the top navigation.
Setup two (feature disabled)
Happy path two (feature disabled)
Open the Web UI and observe that the news fetch feature is disabled, since the environment variable is set to disable it, as described in the documentation. This is evident by the megaphone icon being omitted from the top navigation and the Web UI not making a request for the feed.