Add versioned PollerGroupsInfo, deprecate poller_group_infos#819
Merged
Conversation
cbsandeep10
force-pushed
the
sb/poller-groups-version
branch
from
2492391 to
dd104c2
Compare
Introduce a PollerGroupsInfo message carrying a monotonically increasing version alongside the poller groups, so the SDK can ignore stale snapshots that arrive out of order (e.g. after polls are cancelled during cell migration). Deprecate the repeated poller_group_infos fields in favor of the new poller_groups_info field on DescribeNamespaceResponse and the Poll Workflow/Activity/Nexus TaskQueue responses. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
cbsandeep10
force-pushed
the
sb/poller-groups-version
branch
from
dd104c2 to
b7a58d0
Compare
michaely520
approved these changes
Jul 7, 2026
ShahabT
approved these changes
Jul 7, 2026
yuandrew
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Introduce a
PollerGroupsInfomessage carrying a monotonically increasingversionalongside the poller groups, so the SDK can ignore stale snapshots that arrive out of order (e.g. after polls are cancelled during cell migration).Deprecate the repeated
poller_group_infosfields in favor of the newpoller_groups_infofield onDescribeNamespaceResponseand the Poll Workflow/Activity/Nexus TaskQueue responses.Why?
The server sends poller-group assignment info to the SDK via poll responses. During cell migration, the server cancels in-flight polls and returns updated poller-group info, but responses can arrive out of order — a stale snapshot can land after a fresh one and overwrite it. Attaching a monotonically increasing
versionlets the SDK ignore any snapshot that isn't newer than the one it has already applied, preventing stale overwrites.Breaking changes
None. New fields use fresh field numbers (no reuse), and the old
poller_group_infosfields are only marked[deprecated = true]— still fully wire-compatible.buf breakingagainstmainpasses clean. Consumers referencing the deprecated fields will see deprecation warnings but will not break.