fix: add check for click event handler to prevent popup closure - #855
Open
Incrediblenoble wants to merge 1 commit into
Open
fix: add check for click event handler to prevent popup closure#855Incrediblenoble wants to merge 1 commit into
Incrediblenoble wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #100
The issue is about the DatePicker closing when clicking on the empty space below its cells.
Changes:
src/index.js- The issue was caused by a missing check in the click event handler for the empty space below the cells. The function was only checking if the clicked element was an instance of Datepicker, but it did not account for the possibility that the clicked element could be another HTML element with the same class as Datepicker.