Skip to content

Update Node and repo dependencies#2521

Merged
amir-ba merged 2 commits into
telekom:mainfrom
amir-ba:copilot/maintenance-node-24
Jun 29, 2026
Merged

Update Node and repo dependencies#2521
amir-ba merged 2 commits into
telekom:mainfrom
amir-ba:copilot/maintenance-node-24

Conversation

@amir-ba

@amir-ba amir-ba commented Jun 29, 2026

Copy link
Copy Markdown
Collaborator

Updates the repository maintenance baseline to Node 24 and refreshes the requested repo-wide dependencies in order.

Summary:

  • Set the repo Node engine and GitHub workflow Node setup versions to 24.
  • Updated replace-in-file, rimraf, and lerna with Yarn installs after each step.
  • Migrated the Lerna 9 bootstrap path by delegating workspace linking to Yarn and removing the legacy useWorkspaces option.
  • Stabilized visual tests under Node 24 by binding the local static server for Docker Chromium, supporting Storybook's #storybook-root, increasing Jest timeout, and running the Docker Chromium suite serially.

Validation:

  • yarn build
  • wrapper builds
  • yarn workspace @telekom/scale-storybook-vue build --quiet
  • yarn bootstrap
  • focused visual checks for previously flaky suites
  • yarn workspace @telekom/scale-visual-tests test:m1: 29 passed, 9 skipped, 392 tests passed, 464 snapshots passed

@amir-ba
amir-ba requested a review from maomaoZH as a code owner June 29, 2026 16:00
Copilot AI review requested due to automatic review settings June 29, 2026 16:00

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the repo’s maintenance baseline to Node 24, refreshes several repo-wide dependencies (notably Lerna and rimraf), and adjusts the visual-test harness to reduce flakiness under the new runtime.

Changes:

  • Bump Node engine and GitHub Actions workflow Node versions from 22 → 24.
  • Upgrade tooling dependencies (lerna, replace-in-file, rimraf) and migrate away from lerna bootstrap/useWorkspaces.
  • Stabilize visual tests (server binding for Docker Chromium access, Storybook root handling, longer Jest timeout, serial Docker Chromium run).

Reviewed changes

Copilot reviewed 11 out of 12 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
packages/visual-tests/test-environment-setup.js Increases Jest timeout and supports #storybook-root for visual checks/setups.
packages/visual-tests/setup.js Binds the Storybook static server to 0.0.0.0 for Docker Chromium connectivity.
packages/visual-tests/package.json Runs the Docker Chromium visual-test suite serially and upgrades rimraf.
packages/components/package.json Upgrades rimraf.
packages/components-vue/package.json Upgrades rimraf.
packages/components-react/package.json Upgrades rimraf.
package.json Switches bootstrap to Yarn install semantics, upgrades lerna/replace-in-file/rimraf, and bumps Node engine to 24.x.
lerna.json Removes legacy useWorkspaces config.
.github/workflows/release.yml Updates CI Node version to 24.
.github/workflows/publish.yml Updates CI Node version to 24.
.github/workflows/build-pr.yml Updates CI Node version to 24.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread packages/visual-tests/setup.js
@amir-ba
amir-ba merged commit f317b44 into telekom:main Jun 29, 2026
9 checks passed
@amir-ba
amir-ba deleted the copilot/maintenance-node-24 branch June 29, 2026 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants