Skip to content

Implemented changes requested in a review#13

Merged
felixvons merged 5 commits into
mainfrom
common/implement-review-requests
Jul 10, 2026
Merged

Implemented changes requested in a review#13
felixvons merged 5 commits into
mainfrom
common/implement-review-requests

Conversation

@LeonardBuhl

Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts the developer “frame quick reload” utility to use a dedicated exception type and improves inline documentation around layout-moving behavior during reloads.

Changes:

  • Introduces CustomFrameReloadException and updates reload_module_source() to raise it instead of raw exceptions.
  • Adds a docstring to _move_layout_contents() and tweaks existing docstrings.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread modules/dev/frame_quick_reload.py Outdated
Comment thread modules/dev/frame_quick_reload.py Outdated
Comment thread modules/dev/frame_quick_reload.py
Copilot AI review requested due to automatic review settings July 9, 2026 14:26
@LeonardBuhl LeonardBuhl force-pushed the common/implement-review-requests branch from 622ecc2 to 4c15a1a Compare July 9, 2026 14:26

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

Comment thread modules/dev/frame_quick_reload.py Outdated
Comment thread modules/dev/frame_quick_reload.py Outdated
Comment thread modules/dev/frame_quick_reload.py Outdated
Copilot AI review requested due to automatic review settings July 9, 2026 15:02

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

Comment thread modules/dev/frame_quick_reload.py Outdated
Comment thread modules/dev/frame_quick_reload.py Outdated
Copilot AI review requested due to automatic review settings July 9, 2026 15:06

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

Comment thread modules/dev/frame_quick_reload.py Outdated
Comment thread modules/dev/frame_quick_reload.py Outdated
Copilot AI review requested due to automatic review settings July 9, 2026 15:10

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

Comment thread modules/dev/frame_quick_reload.py
@felixvons felixvons merged commit d0dc9cc into main Jul 10, 2026
3 checks passed
@felixvons felixvons deleted the common/implement-review-requests branch July 10, 2026 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants