Fix: use WARN level and "Notif failure" message for failed notifications (#4800) - #4801
Merged
Conversation
orianar
changed the title
fgalan
reviewed
Jul 23, 2026
| ... | ||
|
|
||
| time=2026-03-12T13:16:09.473Z | lvl=INFO | corr=a280a8ae-1e15-11f1-ae2a-080027207a9f; cbnotif=1 | trans=1773321367-657-00000000004 | from=0.0.0.0 | srv=<none> | subsrv=/ | comp=Orion | op=logTracing.cpp[105]:logInfoHttpNotification | msg=Notif delivered (subId: 69b2bc999bb797a5cd07dc74): POST localhost:9997/giveme400, payload (123 bytes): {"subscriptionId":"69b2bc999bb797a5cd07dc74","data":[{"id":"E1","type":"T","A":{"type":"Number","value":1,"metadata":{}}}]}, response code: 400, response payload (93 bytes): {"error": "FakeError", "description": "this is a forged error response for testing purposes"} | ||
| time=2026-03-12T13:16:09.473Z | lvl=WARN | corr=a280a8ae-1e15-11f1-ae2a-080027207a9f; cbnotif=1 | trans=1773321367-657-00000000004 | from=0.0.0.0 | srv=<none> | subsrv=/ | comp=Orion | op=logTracing.cpp[105]:logInfoHttpNotification | msg=Notif failure (subId: 69b2bc999bb797a5cd07dc74): POST localhost:9997/giveme400, payload (123 bytes): {"subscriptionId":"69b2bc999bb797a5cd07dc74","data":[{"id":"E1","type":"T","A":{"type":"Number","value":1,"metadata":{}}}]}, response code: 400, response payload (93 bytes): {"error": "FakeError", "description": "this is a forged error response for testing purposes"} |
Member
There was a problem hiding this comment.
I think this case should be changed
The "failure" semantics for notifications is "the notification hasn't reached the destination" no matter the response code of the receiver (either 2xx, 4xx or 5xx). This is somehow confirmed by alarm ID 5 type in this table
The change INFO -> WARN and "Notif delivered" -> "Notif failure" is ok for the following cases shown in this documentation:
- Couldn't connect to server
- Timeout was reached
- Couldn't resolve host name
fgalan
reviewed
Jul 24, 2026
| } | ||
|
|
||
| LM_I(("Notif delivered (subId: %s): %s %s%s, payload (%d bytes): %s, response code: %s", subId, verb, endpoint, resource, strlen(payload), effectivePayload, reason)); | ||
| LM_W(("Notif failure (subId: %s): %s %s%s, payload (%d bytes): %s, response code: %s", subId, verb, endpoint, resource, strlen(payload), effectivePayload, reason)); |
Member
There was a problem hiding this comment.
Given that we are changing the structure of the message ("delivered" -> "failure") maybe we should do the same for "response code", as in this case we don't have an actual response code (in the past we did so to have an homogenous format along all the notification log messages)
What about?
Suggested change
| LM_W(("Notif failure (subId: %s): %s %s%s, payload (%d bytes): %s, response code: %s", subId, verb, endpoint, resource, strlen(payload), effectivePayload, reason)); | |
| LM_W(("Notif failure (subId: %s): %s %s%s, payload (%d bytes): %s, reason: %s", subId, verb, endpoint, resource, strlen(payload), effectivePayload, reason)); |
Member
|
@fisuda this PR does some modifications in .md files. It would be great if you could have a look and do a PR with the Japanese sync. Thanks in advance! |
fisuda
added a commit
to fisuda/fiware-orion
that referenced
this pull request
Jul 26, 2026
Contributor
|
I sent the PR #4802. |
fgalan
added a commit
that referenced
this pull request
Jul 27, 2026
(JP) Added documentation about failed notifications (#4801)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #4800