Fix code scanning alert no. 9: Uncontrolled format string - #4635
Draft
fgalan wants to merge 2 commits into
Draft
Conversation
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/telefonicaid/fiware-orion/security/code-scanning/9
To fix the problem, we need to ensure that the
formatstring used in thesnprintffunction is not directly influenced by user input. Instead, we should use a constant format string and pass the user input as an argument to avoid format string vulnerabilities.The best way to fix this issue without changing existing functionality is to replace the
snprintfcall on line 2381 with a constant format string and pass thetextvariable as an argument. This change should be made in thesrc/lib/logMsg/logMsg.cppfile.Suggested fixes powered by Copilot Autofix. Review carefully before merging.