fix(s3): replace deprecated EndpointResolverWithOptionsFunc in initConfig by pujitha24 · Pull Request #1392 · tektoncd/results

pujitha24 · 2026-07-26T18:08:24Z

/kind cleanup

Motivation

initConfig in pkg/api/server/v1alpha2/log/s3.go built the S3 client's
custom-endpoint support (used for S3-compatible backends such as MinIO)
with aws.EndpointResolverWithOptionsFunc and
config.WithEndpointResolverWithOptions. Both are deprecated in
aws-sdk-go-v2 in favor of BaseEndpoint, and the code already carried
//nolint:staticcheck markers to suppress the deprecation warnings.

Approach

Set o.BaseEndpoint directly on s3.Options inside the
s3.NewFromConfig functional options, alongside the existing
o.UsePathStyle = true, only when S3_ENDPOINT is configured. This is
the migration path the SDK itself documents (see the deprecation
comment on s3.Options.EndpointResolver in
vendor/github.com/aws/aws-sdk-go-v2/service/s3/options.go).

The S3_HOSTNAME_IMMUTABLE config value that used to feed the removed
resolver's aws.Endpoint.HostnameImmutable field is no longer read.
This is not a behavior change: UsePathStyle was hardcoded to true
both before and after this change, and per
vendor/github.com/aws/aws-sdk-go-v2/service/s3/serialize_immutable_hostname_bucket.go,
when UsePathStyle is true the bucket is always placed in the request
path regardless of HostnameImmutable's value, so the flag never had
an observable effect in this codebase. S3_REGION continues to flow
into both the client region and the base-endpoint signing region via
config.WithRegion, so signing is unaffected.

Validation

go build ./...
go test ./pkg/api/server/v1alpha2/log/... — passes, including a new
TestInitConfig covering both the custom-endpoint and
default-endpoint branches of initConfig.
gofmt -l and go vet ./pkg/api/server/v1alpha2/log/... — clean.

NONE

Fixes #986

Signed-off-by: Pujitha Paladugu 10557236+pujitha24@users.noreply.github.com

…nfig /kind cleanup # Motivation `initConfig` in pkg/api/server/v1alpha2/log/s3.go built the S3 client's custom-endpoint support (used for S3-compatible backends such as MinIO) with `aws.EndpointResolverWithOptionsFunc` and `config.WithEndpointResolverWithOptions`. Both are deprecated in aws-sdk-go-v2 in favor of `BaseEndpoint`, and the code already carried `//nolint:staticcheck` markers to suppress the deprecation warnings. # Approach Set `o.BaseEndpoint` directly on `s3.Options` inside the `s3.NewFromConfig` functional options, alongside the existing `o.UsePathStyle = true`, only when `S3_ENDPOINT` is configured. This is the migration path the SDK itself documents (see the deprecation comment on `s3.Options.EndpointResolver` in vendor/github.com/aws/aws-sdk-go-v2/service/s3/options.go). The `S3_HOSTNAME_IMMUTABLE` config value that used to feed the removed resolver's `aws.Endpoint.HostnameImmutable` field is no longer read. This is not a behavior change: `UsePathStyle` was hardcoded to `true` both before and after this change, and per vendor/github.com/aws/aws-sdk-go-v2/service/s3/serialize_immutable_hostname_bucket.go, when `UsePathStyle` is true the bucket is always placed in the request path regardless of `HostnameImmutable`'s value, so the flag never had an observable effect in this codebase. `S3_REGION` continues to flow into both the client region and the base-endpoint signing region via `config.WithRegion`, so signing is unaffected. # Validation - `go build ./...` - `go test ./pkg/api/server/v1alpha2/log/...` — passes, including a new `TestInitConfig` covering both the custom-endpoint and default-endpoint branches of `initConfig`. - `gofmt -l` and `go vet ./pkg/api/server/v1alpha2/log/...` — clean. ```release-note NONE ``` Fixes tektoncd#986 Signed-off-by: Pujitha Paladugu <10557236+pujitha24@users.noreply.github.com> Assisted-by: Claude Sonnet 5 (via Claude Code)

linux-foundation-easycla · 2026-07-26T18:08:30Z

The committers listed above are authorized under a signed CLA.

✅ login: pujitha24 / name: Pujitha Paladugu (b3db972, e038837)

Copilot

Pull request overview

Updates Tekton Results’ S3 log backend initialization to align with current aws-sdk-go-v2 guidance by replacing deprecated endpoint resolver APIs with s3.Options.BaseEndpoint for custom S3-compatible endpoints.

Changes:

Simplifies initConfig to always load the default AWS config and sets o.BaseEndpoint when S3_ENDPOINT is provided.
Removes the deprecated EndpointResolverWithOptionsFunc / WithEndpointResolverWithOptions path and associated //nolint:staticcheck suppressions.
Adds TestInitConfig to validate both custom-endpoint and default-endpoint branches.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
pkg/api/server/v1alpha2/log/s3.go	Migrates custom endpoint handling to `s3.Options.BaseEndpoint` and simplifies AWS config loading.
pkg/api/server/v1alpha2/log/s3_test.go	Adds unit coverage for `initConfig` behavior with/without `S3_ENDPOINT`.

Comments suppressed due to low confidence (1)

pkg/api/server/v1alpha2/log/s3_test.go:200

Same as the "with custom endpoint" case: provide dummy S3_ACCESS_KEY_ID / S3_SECRET_ACCESS_KEY values so this test does not depend on when the AWS SDK chooses to validate credentials.

		c := &server.Config{
			S3_REGION: "us-east-1",
		}

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

pujitha24 · 2026-07-26T21:04:08Z

 	return s3.NewFromConfig(awsConfig, func(o *s3.Options) {
 		o.UsePathStyle = true
+		if len(cfg.S3_ENDPOINT) > 0 {
+			o.BaseEndpoint = aws.String(cfg.S3_ENDPOINT)
+		}


Good catch. I went with the lighter option you suggested — documenting that it's ignored rather than removing the field — to avoid breaking existing deployments that already set S3_HOSTNAME_IMMUTABLE in their config. I added a comment on the field in pkg/api/server/config/config.go explaining it's deprecated/ignored (since UsePathStyle is always true, so the bucket is always placed in the path regardless of this value), and updated the description in cmd/api/README.md to say the same. I left config/base/env/config and test/e2e/gcs-emulator.yaml as-is since they just set it to false, which remains harmless.

pujitha24 · 2026-07-26T21:04:10Z

+		c := &server.Config{
+			S3_REGION:   "us-east-1",
+			S3_ENDPOINT: "https://minio.example.com",
+		}


You're right, thanks. I added dummy S3_ACCESS_KEY_ID/S3_SECRET_ACCESS_KEY values to the server.Config in both TestInitConfig subtests ("with custom endpoint" and "without custom endpoint") in pkg/api/server/v1alpha2/log/s3_test.go, so the test doesn't rely on the SDK not validating credentials.

Document that S3_HOSTNAME_IMMUTABLE is deprecated and ignored (the S3 client always uses path-style addressing), instead of silently dropping a config value that used to have an effect. Also set dummy S3 credentials in TestInitConfig so the test doesn't depend on the AWS SDK's credential validation timing. Signed-off-by: Pujitha Paladugu <10557236+pujitha24@users.noreply.github.com> Assisted-by: Claude Sonnet 5 (via Claude Code)

Document that S3_HOSTNAME_IMMUTABLE is deprecated and ignored (the S3 client always uses path-style addressing), instead of silently dropping a config value that used to have an effect. Also set dummy S3 credentials in TestInitConfig so the test doesn't depend on the AWS SDK's credential validation timing. Signed-off-by: Pujitha Paladugu <10557236+pujitha24@users.noreply.github.com>

pujitha24 · 2026-07-27T18:16:37Z

/easycla

pujitha24 · 2026-07-29T15:41:59Z

/retest

pujitha24 · 2026-08-10T18:27:10Z

/assign @divyansh42

tekton-robot · 2026-08-18T19:14:33Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please ask for approval from divyansh42 after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copilot AI review requested due to automatic review settings July 26, 2026 18:08

tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Jul 26, 2026

tekton-robot requested review from divyansh42 and enarha July 26, 2026 18:08

tekton-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 26, 2026

Copilot started reviewing on behalf of pujitha24 July 26, 2026 18:08 View session

Copilot AI reviewed Jul 26, 2026

View reviewed changes

tekton-robot assigned divyansh42 Aug 10, 2026

pujitha24 force-pushed the auto/issue-986 branch from b3db972 to fb5cdf9 Compare August 18, 2026 19:14

Navigation Menu

Uh oh!

fix(s3): replace deprecated EndpointResolverWithOptionsFunc in initConfig - #1392

fix(s3): replace deprecated EndpointResolverWithOptionsFunc in initConfig#1392
pujitha24 wants to merge 2 commits into
tektoncd:mainfrom
pujitha24:auto/issue-986

pujitha24 commented Jul 26, 2026

Uh oh!

linux-foundation-easycla Bot commented Jul 26, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

pujitha24 Jul 26, 2026

Uh oh!

pujitha24 Jul 26, 2026

Uh oh!

pujitha24 commented Jul 27, 2026

Uh oh!

pujitha24 commented Jul 29, 2026

Uh oh!

pujitha24 commented Aug 10, 2026

Uh oh!

tekton-robot commented Aug 18, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

pujitha24 commented Jul 26, 2026

Motivation

Approach

Validation

Uh oh!

linux-foundation-easycla Bot commented Jul 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

pujitha24 Jul 26, 2026

Choose a reason for hiding this comment

Uh oh!

pujitha24 Jul 26, 2026

Choose a reason for hiding this comment

Uh oh!

pujitha24 commented Jul 27, 2026

Uh oh!

pujitha24 commented Jul 29, 2026

Uh oh!

pujitha24 commented Aug 10, 2026

Uh oh!

tekton-robot commented Aug 18, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

linux-foundation-easycla Bot commented Jul 26, 2026 •

edited

Loading