fix: allow debug.breakpoints.beforeSteps without onFailure - #10836
Closed
aniketatgithub wants to merge 1 commit into
Closed
aniketatgithub wants to merge 1 commit into
aniketatgithub wants to merge 1 commit into
Conversation
The validation gate rejected any TaskRun with a non-nil breakpoints block whose onFailure was empty, even though both fields are optional in the API and the runtime treats them independently. Remove the empty-onFailure rejection from both v1 and v1beta1 validators; the invalid-value check for non-enabled values remains. Fixes tektoncd#9719. Signed-off-by: Aniket <aniketkomailkro@gmail.com>
tekton-robot
added
the
release-note
Author
|
/kind bug |
|
tekton-robot
added
kind/bug
Collaborator
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Author
|
Closing for now since I can't complete the CLA signing process. Happy for someone else to pick this up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Fixes #9719
validateDebugrejected any TaskRun with a non-nilbreakpointsblock whoseonFailurewas empty, even though bothonFailureandbeforeStepsare+optionalonTaskBreakpointsand the runtime treats them independently (NeedsDebugOnFailure()returns false for empty;NeedsDebugBeforeStep()/HaveBeforeSteps()work alone). The empty-onFailure rejection was a side effect of an earlier volume-related fix and was never intended as a requirement.This removes the empty-onFailure rejection from both
v1andv1beta1validateDebug. The remaining check only fires whenonFailureis set to a value other thanenabled. AddedTestTaskRunSpec_ValidateDebugBreakpointstable tests (beforeSteps-only valid, empty breakpoints valid,enabledvalid, invalid value rejected, duplicate beforeSteps rejected) in both packages.Submitter Checklist
Release Notes