hack: add etcd revision profiling helper - #10834
Open
waveywaves wants to merge 2 commits into
Open
waveywaves wants to merge 2 commits into
waveywaves wants to merge 2 commits into
Conversation
Extracted from the helper originally contributed in tektoncd#10329. Signed-off-by: thc1006 <84045975+thc1006@users.noreply.github.com>
Signed-off-by: waveywaves <11972233+waveywaves@users.noreply.github.com>
Collaborator
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
6 of 8 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #10834 +/- ##
=======================================
Coverage 90.81% 90.81%
=======================================
Files 292 292
Lines 22196 22196
=======================================
Hits 20158 20158
Misses 2036 2036
Partials 2 2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
Author
|
/retest |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Carries forward the optional profiling helper from #10329 by @thc1006. The extracted implementation commit preserves @thc1006 as its author; the follow-up commit adapts it to current
mainand addresses the remaining review risks.Add
hack/etcd-revision-profile, an operator helper that reports the per-key write count and current serialized size of a PipelineRun, its TaskRuns, their Pods, and related Events. Reads are pinned to the PipelineRun's etcd revision, membership is checked through owner references and UIDs, and incomplete profiles fail unless explicitly accepted.The helper lists Events once per namespace, verifies object identity through API rechecks rather than raw-value substring matching, supports encrypted stored values without a verification bypass, and forces the etcdctl v3 API.
The companion profiling guide is in #10826. This PR implements optional deliverable 3 of #10322.
Validation:
go test ./hack/etcd-revision-profile -count=1go vet ./hack/etcd-revision-profilegolangci-lint v2.12.2 run --modules-download-mode=vendor --max-issues-per-linter=0 --max-same-issues=0 --timeout 5m --new-from-rev=origin/main/kind feature
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes