fix(deps): bump OTel SDK with knative.dev/pkg semconv alignment - #10825
infernus01 wants to merge 1 commit into
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #10825 +/- ##
=======================================
Coverage 90.74% 90.74%
=======================================
Files 294 294
Lines 22304 22304
=======================================
Hits 20240 20240
Misses 2062 2062
Partials 2 2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Signed-off-by: Shubham Bhardwaj <shubbhar@redhat.com>
2c271e9 to
87b4168
Compare
| go.opentelemetry.io/otel/sdk v1.44.0 | ||
| go.opentelemetry.io/otel/sdk/metric v1.44.0 | ||
| go.opentelemetry.io/otel/trace v1.44.0 | ||
| go.opentelemetry.io/otel v1.45.0 |
There was a problem hiding this comment.
OTel v1.45 changes WithEndpointURL so a pathless endpoint is used as / instead of receiving the signal-specific suffix. Knative still passes the HTTP tracing-endpoint and metrics-endpoint from config-observability directly to this option. I reproduced http://collector:4318 sending to /v1/traces at the merge base but / at this head; metrics changes analogously from /v1/metrics to /. Existing configurations can therefore keep running while silently failing to export telemetry. Could we preserve the existing default paths—preferably through a Knative fix followed by a bump here—and add regression coverage for pathless endpoints?
from Vibhav's Pi
Changes
Bumps knative.dev/pkg to v0.0.0-20260918182429-5dc1978f0042to address a startup panic caused by conflicting OpenTelemetry schema URLs.
The dependabot next dependency combination uses OTel components with different schema versions: https://opentelemetry.io/schemas/1.43.0 and https://opentelemetry.io/schemas/1.41.0. At startup, knative.dev/pkg/observability/resource.Default() calls resource.Merge(), which detects the conflicting schema URLs and panics (exit code 2, CrashLoopBackOff).
Fix: Align the knative.dev/pkg dependency with the OTel SDK version used by the application so that observability resources use a consistent schema URL and the controller can start successfully.
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes