chore: delete dead code in test/per_feature_flags_test.go file - #10802
Conversation
|
/kind chore |
|
@zakisk: The label(s) DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/kind cleanup |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #10802 +/- ##
=======================================
Coverage 90.70% 90.70%
=======================================
Files 295 295
Lines 22535 22535
=======================================
Hits 20440 20440
Misses 2093 2093
Partials 2 2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
f27fbd2 to
500f734
Compare
test/per_feature_flags_test.go file has system namespace retrieve code from env and fallback to hardcoded value but that ns value is never used in code so deletes it. Signed-off-by: Zaki Shaikh <zashaikh@redhat.com>
500f734 to
e03a67d
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Changes
test/per_feature_flags_test.go file has system namespace retrieve code from env and fallback to hardcoded value but that ns value is never used in code so deletes it.
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes