refactor(env): read NODE_ENV through the typed env#58
Merged
Conversation
constants.ts and store/index.ts read process.env.NODE_ENV directly while the rest of the app already goes through the validated @teispace/env config. Route them through env.NODE_ENV (shared group) so the typed, validated env is the single source of truth for runtime config.
Contributor
Author
|
⏸️ Blocked on the env publish age gate (resume ~2026-06-21 14:00 UTC). This PR's CI was failing because That's fixed in To land this PR: bump the dep to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
constants.tsandstore/index.tsreadprocess.env.NODE_ENVdirectly while the rest of the app already goes through the validated@teispace/envconfig. This routes them throughenv.NODE_ENV(the shared group) so the typed, validated env is the single source of truth for runtime config.Changes
src/lib/config/constants.ts—isProduction/isDevelopment/isTestnow readenv.NODE_ENV.src/store/index.ts—devToolstoggle readsenv.NODE_ENV.next.config.ts'sprocess.env.ANALYZEis intentionally left raw — it's a build-time toggle, not part of the app's runtime env contract.Test plan
yarn type-checkcleanyarn lintclean (no new errors)yarn test— 149 tests pass