Implement option for custom redirect URL & Fixes sessions for users not in local database #11 - #1
Merged
Merged
Conversation
Implement configuration parameter for OIDC redirect URL. Useful for setups behind reverse proxies where the URL is incorrectly detected leading to non working redirects
Users not in the user database could not use cookies due to the nature of the cookie itself and the check implemented by yourls. As such an additional cookie is created stored the username and an additional check is introduced in the plugin to validate the cookie against such username. The username cookie has the same security properties as the one set by yourls and is deleted upon logout.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See joshp23#11