fix(lighthouse): use newline-separated URLs and checkout@v4#91
Merged
Conversation
The treosh/lighthouse-ci-action urls input expects newline-separated strings, not a JSON array. Passing a JSON array caused INVALID_URL errors. Also fix actions/checkout from v6 (nonexistent) to v4.
|
Caution Review failedPull request was closed or merged during review 📝 WalkthroughWalkthroughThe Lighthouse scan workflow now exports its URL list as newline-delimited output for ChangesLighthouse scan workflow
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
treosh/lighthouse-ci-actionurlsinput expects a newline-separated string, not a JSON array. Passing["https://tehwolf.de"]causedINVALID_URL/LighthouseError: INVALID_URLactions/checkout@v6→@v4(v6 does not exist, causing workflow failures)Test plan
weekly lighthouse scanworkflow viaworkflow_dispatchafter mergeINVALID_URLerrorSummary by CodeRabbit