Skip to content

fix(lighthouse): use newline-separated URLs and checkout@v4#91

Merged
tehw0lf merged 3 commits into
mainfrom
fix/lighthouse-url-format
Jun 25, 2026
Merged

fix(lighthouse): use newline-separated URLs and checkout@v4#91
tehw0lf merged 3 commits into
mainfrom
fix/lighthouse-url-format

Conversation

@tehw0lf

@tehw0lf tehw0lf commented Jun 25, 2026

Copy link
Copy Markdown
Owner

Summary

  • The treosh/lighthouse-ci-action urls input expects a newline-separated string, not a JSON array. Passing ["https://tehwolf.de"] caused INVALID_URL / LighthouseError: INVALID_URL
  • Fix the URL output to use heredoc multiline format so each URL is on its own line
  • Fix actions/checkout@v6@v4 (v6 does not exist, causing workflow failures)

Test plan

  • Trigger the weekly lighthouse scan workflow via workflow_dispatch after merge
  • Confirm Lighthouse runs without INVALID_URL error
  • Confirm results table appears in workflow summary

Summary by CodeRabbit

  • Chores
    • Improved the Lighthouse scan workflow’s URL handling for more reliable audits when multiple pages are included.
    • Updated a workflow dependency to a newer version for better compatibility and maintenance.

tehw0lf added 3 commits June 24, 2026 22:30
The treosh/lighthouse-ci-action urls input expects newline-separated
strings, not a JSON array. Passing a JSON array caused INVALID_URL errors.
Also fix actions/checkout from v6 (nonexistent) to v4.
@coderabbitai

coderabbitai Bot commented Jun 25, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

Pull request was closed or merged during review

📝 Walkthrough

Walkthrough

The Lighthouse scan workflow now exports its URL list as newline-delimited output for $GITHUB_OUTPUT and updates actions/checkout to v4. The scan job structure and reporting steps stay the same.

Changes

Lighthouse scan workflow

Layer / File(s) Summary
URL export and checkout update
.github/workflows/lighthouse-scan.yml
The workflow reads inputs.urls as lines, appends the base URL with newline separation, exports urls via a multiline $GITHUB_OUTPUT entry, and updates actions/checkout to v4.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • tehw0lf/workflows#89: This earlier PR introduced the Lighthouse workflow that this change now modifies by adjusting URL assembly and tooling versioning.

Poem

🐇 I hopped through URLs, one line at a time,
Base URL tucked in a newline rhyme.
The scanner blinked and sprang to light,
With checkout dressed a bit more right.
Hoppy scans and tidy trails! 🌿

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main workflow fix: newline-separated Lighthouse URLs and the checkout version update.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/lighthouse-url-format

Comment @coderabbitai help to get the list of available commands.

@tehw0lf tehw0lf merged commit 2c2b297 into main Jun 25, 2026
2 of 3 checks passed
@tehw0lf tehw0lf deleted the fix/lighthouse-url-format branch June 25, 2026 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant