fix: add support for bcrypt "$2b$" format in import password validation - #2850
Open
FreddyDevelop wants to merge 1 commit into
Open
fix: add support for bcrypt "$2b$" format in import password validation#2850FreddyDevelop wants to merge 1 commit into
FreddyDevelop wants to merge 1 commit into
Conversation
lfleischmann
approved these changes
Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The 2a and 2b format are basically the same and as you can see in the source code the
CompareHashAndPasswordfunction only checks if the major version (2) matches and not the minor version (aorb)Tests
Import a password with a different version (
2b) and check that login succeeds.