Skip to content

feat: make oauth client secret config optional #2343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MarcoScabbiolo wants to merge 8 commits into
base: main
Choose a base branch
from
Open

feat: make oauth client secret config optional #2343

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
3da7c34
feat: make oauth client secret config optional
Dec 16, 2025
4f14180
Merge branch 'main' into optional-oauth-client-secret
MarcoScabbiolo Dec 17, 2025
9ff51d0
Merge branch 'main' into optional-oauth-client-secret
MarcoScabbiolo Dec 18, 2025
8121228
Merge branch 'main' into optional-oauth-client-secret
MarcoScabbiolo Dec 18, 2025
f3e95ce
Merge branch 'main' of https://github.com/teamhanko/hanko into option…
Jun 22, 2026
df7c7af
Merge branch 'optional-oauth-client-secret' of https://github.com/Mar…
Jun 22, 2026
89409b0
Merge branch 'main' of https://github.com/teamhanko/hanko into option…
Jul 27, 2026
702ea4f
Merge branch 'main' of https://github.com/teamhanko/hanko into option…
Jul 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions backend/config/config_third_party.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,9 +311,6 @@ func (p *CustomThirdPartyProvider) Validate() error {
if p.ClientID == "" {
return errors.New("missing client_id")
}
if p.Secret == "" {
return errors.New("missing client secret")
}
if len(p.Scopes) == 0 {
return errors.New("missing scopes")
}
Expand Down Expand Up @@ -490,9 +487,6 @@ func (p *ThirdPartyProvider) Validate() error {
if p.ClientID == "" {
return errors.New("missing client ID")
}
if p.Secret == "" {
return errors.New("missing client secret")
}
}
return nil
}