Skip to content

fix(pnpm): reuse cached builds in the engine rebuild #10788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zkochan merged 2 commits into from
Oct 11, 2026
Merged

fix(pnpm): reuse cached builds in the engine rebuild #10788

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f7f1bd4
fix(pnpm): pass skipIfHasSideEffectsCache to the engine rebuild
zkochan Oct 11, 2026
43ac490
chore(deps): bump @pnpm/napi to 12.12.1
zkochan Oct 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
152 changes: 76 additions & 76 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 6 additions & 4 deletions scopes/dependencies/pnpm/lynx.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -493,10 +493,9 @@ export async function install(
}
return {
dependenciesChanged,
// The engine has no skipIfHasSideEffectsCache selector; a pending rebuild
// is expressed as a selection of the packages the lockfile records as
// needing a build.
rebuild: async ({ pending } = {}) => {
// A pending rebuild is expressed as a selection of the packages the
// lockfile records as needing a build.
rebuild: async ({ pending, skipIfHasSideEffectsCache } = {}) => {
const selectedNames = pending ? await pendingBuildNames(rootDir, depsRequiringBuild) : undefined;
if (selectedNames?.length === 0) return;
// Reached without an install of its own after a dry run.
Expand All @@ -513,6 +512,9 @@ export async function install(
...installOptions,
storeDir: resolvedStoreDir,
reporter: options.hidePackageManagerOutput ? undefined : toReporterOptions(rebuildReportOptions),
// A selected package the side-effects cache already holds a build
// of is restored from it instead of running its scripts again.
skipIfHasSideEffectsCache,
},
undefined,
selectedNames,
Expand Down
2 changes: 1 addition & 1 deletion workspace.jsonc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@
"@pnpm/deps.path": "1100.1.0",
"@pnpm/error": "1100.1.1",
"@pnpm/lockfile.types": "1100.0.19",
"@pnpm/napi": "12.12.0",
"@pnpm/napi": "12.12.1",
"@pnpm/network.ca-file": "3.0.3",
"@pnpm/network.fetch": "1100.1.11",
"@pnpm/node-fetch": "^1.0.0",
Expand Down
Loading