Repository navigation
perf(objects): copy small Source contents out of the shared inflate buffer - #10785
Merged
Merged
Conversation
PR Summary by QodoReduce memory retained by small parsed Source objects
AI Description
Diagram
High-Level Assessment
Files changed (2)
|
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewTip of the day💡 Did you know, you can show, collapse, or hide each part of a finding: code, evidence, and all |
GiladShoham
approved these changes
Oct 9, 2026
davidfirst
enabled auto-merge (squash)
October 9, 2026 15:24
|
Code review by qodo was updated up to the latest commit 96b49c7 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
zlib.inflatereturns results smaller than its 16KB chunk as a slice of a 16KB buffer.Source.parsekept that slice, so every small file loaded from the scope held 16KB.bit statusin this repo loads ~3.2k head-version files (~11MB of content) that held ~55MB.Source.parsenow copies the contents when they use less than half of the underlying buffer (small copies come from Node's shared pool). Onbit status, external/buffer memory dropped from ~105MB to ~62MB.