Add hood conversion helpers for pulse-width to motor-rotation migration#1
Draft
LTeixeira4909 wants to merge 1 commit into
Draft
Add hood conversion helpers for pulse-width to motor-rotation migration#1LTeixeira4909 wants to merge 1 commit into
LTeixeira4909 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
frc.robot.subsystems.hood.HoodConversionswith constants for the legacy pulse range and stroke and with three helpers:pulseWidthToTravelMillimeters,travelMillimetersToMotorRotations, andpulseWidthToMotorRotations(uses pinion pitch diameter and motor:pinion ratio).Testing
./gradlew test -qin this environment but the build failed during Gradle script analysis withUnsupported class file major version 69(Java/Gradle toolchain mismatch), so no automated tests were executed.Codex Task