Adapt MPE to work better with different devices#1
Open
RinRin-32 wants to merge 8 commits into
Open
Conversation
…sue, both are on cpu but still triggered this error
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Experiment 1 (only when using
--optim_var) and 4 can now run on MPS device built for M-series Mac.Variance prediction that utilize laplace on 1, 2,3 and 5 cannot run on MPS due to current pytorch implementation limitation related to aten::im2col not being supported on MPS. This current implementation forces experiments needing laplace package to run on CPU if running on a M-series device.
This pull request also address python version issue. Currently on version 3.13, torchvision is not supported on stable channel and is available on nightly only. To overcome this the env yml had to limit python version for the time being.
The env file is now added with pip install of asdfghjkl backend to properly address usage of laplace package.
Clarification about the python version added to env yml is added on readme.