build(deps): @eslint/* の major も ignore に含める - #356
Open
hal-shu-sato wants to merge 1 commit into
Open
Conversation
#352 excluded major updates for eslint but not for @eslint/js, which ships at the same versions, so a major could land on one half of the pair while the other stayed behind. team-apm/apm-data saw exactly that within hours of the equivalent change: team-apm/apm-data#1004 raises @eslint/js to 10.0.1 on its own and leaves eslint at 9.39.5. Widening the entry to @eslint/* keeps the pair moving together, so the eslint 9 -> 10 step is taken deliberately as a single change. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
何を
.github/dependabot.ymlのignoreに@eslint/*を追加します。なぜ
#352 で
eslintの major を除外しましたが、@eslint/jsを入れ忘れていました。両者は同じバージョンで同時にリリースされます。apm-data で同じ設定を入れた数時間後に、dependabot が実際にこの穴を突いてきました(team-apm/apm-data#1004)。
eslintは 9 のまま残るので、同じリリースの片割れだけが major をまたぐ状態になります。ここでも同じことが起きます。@eslint/*に広げれば対になって動くので、eslint 9 → 10 は単独の PR として意図的に上げられます。関連
apm-data は team-apm/apm-data#1010、apm-web にも同じ PR を出しています。apm 本体は
@eslint/jsを依存に持っていないため該当しません。