Skip to content

Fix nightly Rust CI compatibility - #106

Merged
tdenisenko merged 2 commits into
masterfrom
fix/nightly-bail-ci
Jul 17, 2026
Merged

Fix nightly Rust CI compatibility#106
tdenisenko merged 2 commits into
masterfrom
fix/nightly-bail-ci

Conversation

@tdenisenko

Copy link
Copy Markdown
Owner

Summary

This fixes the three failing GitHub Actions jobs on master: Check, Clippy, and Test. All three failed during compilation before tests could run; Format already passed.

Root cause

The repository follows the rolling nightly Rust toolchain. The current GitHub runner compiler now denies semicolon_in_expressions_from_macros, and eyre::bail! expands with a trailing semicolon. Seven call sites in the peer request manager used bail! as the final expression of a block or function, so the new compiler rejected them.

Changes

  • Terminated all seven affected bail! invocations as statements.
  • Preserved the existing early-return behavior and error messages.
  • Kept the fix local to the affected call sites; no dependency or toolchain policy changes were required.
  • Searched the Rust workspace for other expression-position bail! uses and found none requiring changes.

Validation

Passed locally:

  • cargo fmt --all -- --check
  • RUSTFLAGS=-Dsemicolon_in_expressions_from_macros cargo check --workspace
  • cargo check --workspace
  • cargo clippy --workspace -- -D warnings
  • cargo test --workspace
  • git diff --check

The strict-lint workspace check explicitly reproduces the failure mode enforced by the newer GitHub nightly compiler. The full test run passed 689 tests; one benchmark harness remained intentionally ignored.

@tdenisenko
tdenisenko merged commit 40f84fb into master Jul 17, 2026
4 checks passed
@tdenisenko
tdenisenko deleted the fix/nightly-bail-ci branch July 17, 2026 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant