Fix nightly Rust CI compatibility - #106
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes the three failing GitHub Actions jobs on
master: Check, Clippy, and Test. All three failed during compilation before tests could run; Format already passed.Root cause
The repository follows the rolling nightly Rust toolchain. The current GitHub runner compiler now denies
semicolon_in_expressions_from_macros, andeyre::bail!expands with a trailing semicolon. Seven call sites in the peer request manager usedbail!as the final expression of a block or function, so the new compiler rejected them.Changes
bail!invocations as statements.bail!uses and found none requiring changes.Validation
Passed locally:
cargo fmt --all -- --checkRUSTFLAGS=-Dsemicolon_in_expressions_from_macros cargo check --workspacecargo check --workspacecargo clippy --workspace -- -D warningscargo test --workspacegit diff --checkThe strict-lint workspace check explicitly reproduces the failure mode enforced by the newer GitHub nightly compiler. The full test run passed 689 tests; one benchmark harness remained intentionally ignored.