Show aggregate P2P bandwidth on dashboard - #103
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR replaces the dashboard's execution-only
P2P downloadtile with an aggregateP2P bandwidthmetric that shows both download and upload Mbps.The dashboard value now aggregates execution-layer and consensus-layer payload throughput so the main UI reflects the data LogEx is processing across:
What Changed
ExecutionNetworkStatusand download/upload fields toConsensusNetworkStatus.ServeCacheProviderP2P downloadtoP2P bandwidth.↓ download Mbps / ↑ upload Mbps./statustest fixtures and assertions for the new fields.ROADMAP.mdfor the bandwidth dashboard task.Notes
The metric is intentionally application payload throughput, not OS network-interface throughput. This avoids counting unrelated host traffic and gives a better LogEx-specific view, but it does not include encrypted transport framing, TCP/IP overhead, or non-LogEx traffic.
Validation
cargo fmt --checkcargo check -p logex-types -p logex-cl -p logex-sync -p logex-servercargo test -p logex-servercargo test -p logex-sync p2p::serve_cachecargo test -p logex-cl network::testscargo clippy -p logex-types -p logex-cl -p logex-sync -p logex-server -- -D warnings