Recover stale checkpoint restarts - #102
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root Cause
The client previously trusted the persisted
cl/consensus_state.jsonon restart. If the machine was offline long enough, that state and the saved local EL head could fall outside the recent checkpoint window, so startup refused to continue even though the existing verified EL/log data was still usable.The first recovery path also classified a fresh future-only CL anchor as a fatal reorg because it was ahead of the persisted recent-header window. After adding the bridge, the first batch-oriented implementation updated progress once per block immediately after writing an entire chunk, which compressed rate samples into microseconds and produced impossible dashboard logs/sec values.
Implementation Notes
ProgressTrackernow supports batched forward progress updates for contiguous forward chunks.Validation
cargo test -p logex-node archived_consensus_statecargo test -p logex-node restart_guardcargo test -p logex-sync locate_consensus_reorgcargo test -p logex-sync checkpoint_gap_pipeline_depthcargo test -p logex-sync forward_batch_progress_records_one_live_rate_samplecargo clippy -p logex-node -p logex-sync --all-targets -- -D warningsgit diff --checkNotes
Normal historical reverse sync and live tip-following paths are unchanged. The new pipeline is scoped to long-offline checkpoint-gap recovery.