Skip to content

Fix documentation errors in PR #82 review comments#83

Merged
tcrypt25519 merged 2 commits into
ts/cleanfrom
copilot/sub-pr-82
Feb 16, 2026
Merged

Fix documentation errors in PR #82 review comments#83
tcrypt25519 merged 2 commits into
ts/cleanfrom
copilot/sub-pr-82

Conversation

Copilot AI commented Feb 16, 2026

Copy link
Copy Markdown

Addresses 4 documentation inaccuracies identified in PR #82 review.

Changes

  • docs/test_coverage.md: Corrected KECCAK256 status from "Broken" to "Tested" - implementation is working with proper memory-based hashing
  • crates/jet_runtime/src/exec.rs: Fixed Word type documentation from big-endian to little-endian (matches actual implementation using from_le_bytes)
  • docs/process/new-runtime-function.md: Corrected stack helper function name from __stack_pop_1 to stack_pop_1 (no leading underscores in actual API)

All changes are documentation-only corrections aligned with existing implementation and test coverage.


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

@semanticdiff-com

semanticdiff-com Bot commented Feb 16, 2026

Copy link
Copy Markdown

Review changes with  SemanticDiff

Changed Files
File Status
  crates/jet_runtime/src/exec.rs  0% smaller
  docs/process/new-runtime-function.md Unsupported file format
  docs/test_coverage.md Unsupported file format

Co-authored-by: tcrypt25519 <212655132+tcrypt25519@users.noreply.github.com>
Copilot AI changed the title [WIP] Clean up documentation and organization of Jet LLVM-based EVM JIT compiler Fix documentation errors in PR #82 review comments Feb 16, 2026
Copilot AI requested a review from tcrypt25519 February 16, 2026 17:03
@tcrypt25519 tcrypt25519 marked this pull request as ready for review February 16, 2026 17:17
Copilot AI review requested due to automatic review settings February 16, 2026 17:17
@tcrypt25519 tcrypt25519 merged commit 02df543 into ts/clean Feb 16, 2026
2 checks passed

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR corrects four documentation inaccuracies identified during the review of PR #82. All changes align the documentation with the actual implementation and test coverage status. The changes are purely documentation fixes with no code modifications.

Changes:

  • Updated KECCAK256 status from "Broken" to "Tested" in test coverage documentation
  • Fixed Word type endianness documentation from big-endian to little-endian
  • Corrected stack helper function name from __stack_pop_1 to stack_pop_1 in process documentation

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
docs/test_coverage.md Updated KECCAK256 status to reflect working implementation with test coverage (lines 22, 59)
crates/jet_runtime/src/exec.rs Corrected Word type documentation to specify little-endian storage (line 11)
docs/process/new-runtime-function.md Fixed stack helper function name to match actual API without leading underscores (line 118)

tcrypt25519 added a commit that referenced this pull request Feb 16, 2026
* docs: Uodate architecture doc.

* tweak: Reduce non-required pub visibility.

* docs: Add rustdoc comments.

* docs: Update docs.

* fix

* chore: CI change 🤖

* Fix documentation errors in PR #82 review comments (#83)

* Initial plan

* fix: address PR #82 review comments - correct documentation errors

Co-authored-by: tcrypt25519 <212655132+tcrypt25519@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: tcrypt25519 <212655132+tcrypt25519@users.noreply.github.com>

---------

Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
Co-authored-by: tcrypt25519 <212655132+tcrypt25519@users.noreply.github.com>
tcrypt25519 added a commit that referenced this pull request Feb 16, 2026
* docs: Uodate architecture doc.

* tweak: Reduce non-required pub visibility.

* docs: Add rustdoc comments.

* docs: Update docs.

* fix

* chore: CI change 🤖

* Fix documentation errors in PR #82 review comments (#83)

* Initial plan

* fix: address PR #82 review comments - correct documentation errors

Co-authored-by: tcrypt25519 <212655132+tcrypt25519@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: tcrypt25519 <212655132+tcrypt25519@users.noreply.github.com>

---------

Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
Co-authored-by: tcrypt25519 <212655132+tcrypt25519@users.noreply.github.com>
@tcrypt25519 tcrypt25519 deleted the copilot/sub-pr-82 branch February 16, 2026 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants