Skip to content

Fix gravity feed pipe extracting items at much higher speed than intended #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
multiplemonomials merged 2 commits into from
Sep 27, 2025
Merged

Fix gravity feed pipe extracting items at much higher speed than intended #205

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
653ca8c
Fix gravity feed pipe tick count never resetting
multiplemonomials Sep 27, 2025
110f940
Buff default gravity pipe speed
multiplemonomials Sep 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/buildcraft/additionalpipes/APConfiguration.java
View file
Open in desktop

@Munchy907 Munchy907 Sep 27, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't this be 200? making it every 10 seconds. Because 48 was define as 480 in config

@multiplemonomials multiplemonomials Sep 27, 2025

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm confused, a value of 48 here should map 1:1 to a value of 48 in the config. That seems to be how it is on my machine at least...

@Munchy907 Munchy907 Sep 27, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I must of added an extra 0 to my config at some point. Ignore me

@multiplemonomials multiplemonomials Sep 27, 2025

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah np!

Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ else if(powerTransmittanceCfg < 0.0)
waterPerTickProperty.setComment("Amount of water the Water Pump Pipe produces in millibuckets/tick");
waterPumpWaterPerTick = waterPerTickProperty.getInt();

Property gpPullRateProperty = config.get(Configuration.CATEGORY_GENERAL, "gravityFeedPipeTicksPerPull", 48);
Property gpPullRateProperty = config.get(Configuration.CATEGORY_GENERAL, "gravityFeedPipeTicksPerPull", 20);
gpPullRateProperty.setComment("How many ticks the Gravity Feed Pipe needs to extract an item");
gravityFeedPipeTicksPerPull = gpPullRateProperty.getInt();

Expand Down
2 changes: 1 addition & 1 deletion src/main/java/buildcraft/additionalpipes/pipes/PipeBehaviorGravityFeed.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ public void onTick()
{
((PipeFlowItems)pipe.getFlow()).tryExtractItems(1, EnumFacing.UP, null, StackFilter.ALL, false);
}

ticksSincePull = 0;
}
}

Expand Down